Skip to content

refactor(shared): rename clerk-rq directory to query#8445

Merged
jacekradko merged 14 commits intomainfrom
jacek/rename-clerk-rq-dir
May 5, 2026
Merged

refactor(shared): rename clerk-rq directory to query#8445
jacekradko merged 14 commits intomainfrom
jacek/rename-clerk-rq-dir

Conversation

@jacekradko
Copy link
Copy Markdown
Member

Summary

Renames packages/shared/src/react/clerk-rq/packages/shared/src/react/query/. The rq shorthand was opaque ("react-query"); query/ reads naturally and matches the existing function vocabulary (useClerkQuery, getClerkQueryClient, useClerkInfiniteQuery).

Pure directory rename — no behavior change, no public surface change. The clerk-rq path was internal to @clerk/shared (which itself is described as an internal SDK utility package); not exposed via subpath exports, not referenced in any CHANGELOG or docs.

11 files relocated, 16 import sites updated, two doc comments refreshed. The stable __tag: 'clerk-rq-client' runtime identifier in mocks/clerk.ts is intentionally untouched to avoid behavior churn.

Stacking

Based on jacek/clerk-rq-invert-ownership (#8434). Will need to be retargeted to main once that PR merges, or merged through it.

Test plan

  • pnpm --filter @clerk/shared test — 1076 tests pass, no type errors
  • pnpm --filter @clerk/shared build — clean
  • grep clerk-rq returns only the deliberate runtime tag and the parent PR's changeset

@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 5, 2026 3:59pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2026

🦋 Changeset detected

Latest commit: ccb282c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Member

@wobsoriano wobsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Base automatically changed from jacek/clerk-rq-invert-ownership to main May 5, 2026 00:07
…-dir

# Conflicts:
#	packages/shared/src/react/hooks/__tests__/mocks/clerk.ts
#	packages/shared/src/react/index.ts
#	packages/shared/src/react/query/__tests__/clerk-query-client.spec.ts
#	packages/shared/src/react/query/clerk-query-client.ts
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b578d8d8-f282-4a21-acc7-1d71403c22a8

📥 Commits

Reviewing files that changed from the base of the PR and between e950f20 and edca0c0.

📒 Files selected for processing (12)
  • packages/shared/src/keyless/nodeFileStorage.ts
  • packages/shared/src/organization.ts
  • packages/shared/src/react/billing/useInitializePaymentMethod.tsx
  • packages/shared/src/react/billing/useStripeClerkLibs.tsx
  • packages/shared/src/react/billing/useStripeLoader.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOrganizationCreationDefaults.tsx
  • packages/shared/src/react/hooks/usePaymentAttemptQuery.tsx
  • packages/shared/src/react/hooks/usePlanDetailsQuery.tsx
  • packages/shared/src/react/hooks/useStatementQuery.tsx
  • packages/shared/src/react/hooks/useSubscription.tsx
  • packages/shared/src/react/hooks/useUserEnterpriseConnections.tsx
✅ Files skipped from review due to trivial changes (11)
  • packages/shared/src/react/billing/useInitializePaymentMethod.tsx
  • packages/shared/src/react/hooks/useUserEnterpriseConnections.tsx
  • packages/shared/src/react/billing/useStripeClerkLibs.tsx
  • packages/shared/src/react/hooks/usePlanDetailsQuery.tsx
  • packages/shared/src/react/billing/useStripeLoader.tsx
  • packages/shared/src/react/hooks/usePaymentAttemptQuery.tsx
  • packages/shared/src/organization.ts
  • packages/shared/src/react/hooks/useOrganizationCreationDefaults.tsx
  • packages/shared/src/keyless/nodeFileStorage.ts
  • packages/shared/src/react/hooks/useSubscription.tsx
  • packages/shared/src/react/hooks/useStatementQuery.tsx

📝 Walkthrough

Walkthrough

This pull request renames internal React query import paths across the shared package: files that previously imported from ../clerk-rq/* now import from ../query/*. The change touches multiple hooks, billing utilities, test mocks, and the package re-exports; small JSDoc/comment formatting edits and an empty changeset file were also added. No runtime logic, function signatures, or exported API shapes were modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: renaming the clerk-rq directory to query, which matches the scope of the changeset.
Description check ✅ Passed The PR description provides relevant context about the directory rename, rationale for the change, scope of updates, test results, and stacking information, all directly related to the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 5, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8445

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8445

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8445

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8445

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8445

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8445

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8445

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8445

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8445

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8445

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8445

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8445

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8445

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8445

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8445

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8445

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8445

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8445

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8445

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8445

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8445

commit: ccb282c

@jacekradko jacekradko merged commit 1c1845b into main May 5, 2026
43 checks passed
@jacekradko jacekradko deleted the jacek/rename-clerk-rq-dir branch May 5, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants